[master] Update dependencies from dotnet/arcade #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dotnet-maestro[bot]](https://avatars.githubusercontent.com/in/16706?s=60&v=4){kind=small}
…724.1 Microsoft.DotNet.Arcade.Sdk From Version 5.0.0-beta.20117.3 -> To Version 5.0.0-beta.20374.1
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
sharwell
approved these changes
Jul 29, 2020
JoeRobich
force-pushed
the
darc-master-5ea68984-63a6-4436-99ec-565f4648f17b
branch
from
8de48b1 to
aabdb0e
Compare
|
If I don't define DOTNET_ROOT, all the .netcoreapp3.1 MSTest and NUnit tests fail with (https://dev.azure.com/dnceng/public/_build/results?buildId=749215&view=results) Microsoft (R) Test Execution Command Line Tool Version 16.7.0
Copyright (c) Microsoft Corporation. All rights reserved.
Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
! Testhost process exited with error: A fatal error occurred, the required library hostfxr.dll could not be found.
If this is a self-contained application, that library should exist in [F:\workspace\_work\1\s\artifacts\bin\Microsoft.CodeAnalysis.VisualBasic.CodeRefactoring.Testing.MSTest.UnitTests\Release\netcoreapp3.1\].
If this is a framework-dependent application, install the runtime in the default location [C:\Program Files\dotnet] or use the DOTNET_ROOT environment variable to specify the runtime location.
. Please check the diagnostic logs for more information.
Test Run Aborted.
Results File: F:\workspace\_work\1\s\artifacts\TestResults\Release\Microsoft.CodeAnalysis.VisualBasic.CodeRefactoring.Testing.MSTest.UnitTests_netcoreapp3.1_x64.xml
=== COMMAND LINE ===
F:\workspace\_work\1\s\.dotnet\dotnet.exe test F:\workspace\_work\1\s\artifacts\bin\Microsoft.CodeAnalysis.VisualBasic.CodeRefactoring.Testing.MSTest.UnitTests\Release\netcoreapp3.1\Microsoft.CodeAnalysis.VisualBasic.CodeRefactoring.Testing.MSTest.UnitTests.dll --logger:"console;verbosity=normal" --logger:"trx;LogFileName=Microsoft.CodeAnalysis.VisualBasic.CodeRefactoring.Testing.MSTest.UnitTests_netcoreapp3.1_x64.xml" "--ResultsDirectory:F:\workspace\_work\1\s\artifacts\TestResults\Release" "--Framework:.NETCoreApp,Version=v3.1" > "F:\workspace\_work\1\s\artifacts\log\Release\Microsoft.CodeAnalysis.VisualBasic.CodeRefactoring.Testing.MSTest.UnitTests_netcoreapp3.1_x64.log" 2>&1If I do define DOTNET_ROOT, all the .netcoreapp1.1 MSTest and NUnit tests fail with (https://dev.azure.com/dnceng/public/_build/results?buildId=749296&view=results) Microsoft (R) Test Execution Command Line Tool Version 16.7.0
Copyright (c) Microsoft Corporation. All rights reserved.
Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
! Unable to find F:\workspace\_work\1\s\artifacts\bin\Microsoft.CodeAnalysis.Testing.Verifiers.MSTest.UnitTests\Release\netcoreapp1.1\testhost.dll. Please publish your test project and retry.
Test Run Aborted.
Results File: F:\workspace\_work\1\s\artifacts\TestResults\Release\Microsoft.CodeAnalysis.Testing.Verifiers.MSTest.UnitTests_netcoreapp1.1_x64.xml
=== COMMAND LINE ===
F:\workspace\_work\1\s\.dotnet\dotnet.exe test F:\workspace\_work\1\s\artifacts\bin\Microsoft.CodeAnalysis.Testing.Verifiers.MSTest.UnitTests\Release\netcoreapp1.1\Microsoft.CodeAnalysis.Testing.Verifiers.MSTest.UnitTests.dll --logger:"console;verbosity=normal" --logger:"trx;LogFileName=Microsoft.CodeAnalysis.Testing.Verifiers.MSTest.UnitTests_netcoreapp1.1_x64.xml" "--ResultsDirectory:F:\workspace\_work\1\s\artifacts\TestResults\Release" "--Framework:.NETCoreApp,Version=v1.1" > "F:\workspace\_work\1\s\artifacts\log\Release\Microsoft.CodeAnalysis.Testing.Verifiers.MSTest.UnitTests_netcoreapp1.1_x64.log" 2>&1 |
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
|
If we remove the package reference, we see this error in the following build |
Auto-Merge StatusThis pull request has been merged because the following merge policies have succeeded.
|
JoeRobich
force-pushed
the
darc-master-5ea68984-63a6-4436-99ec-565f4648f17b
branch
from
ef6a384 to
c82221f
Compare
…724.1 Microsoft.DotNet.Arcade.Sdk From Version 5.0.0-beta.20117.3 -> To Version 5.0.0-beta.20374.1
Support for netcoreapp1.1 was removed in microsoft/vstest#2067 and microsoft/vstest#2192, so we can no longer take updates to this package.
dotnet-maestro
bot
deleted the
darc-master-5ea68984-63a6-4436-99ec-565f4648f17b
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the following dependencies
From https://github.com/dotnet/arcade